Initial implementation for chat template parameters #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
clefourrier
reviewed
Aug 6, 2025
clefourrier
reviewed
Aug 6, 2025
| matches = pattern.findall(args) | ||
| for key, value in matches: | ||
| key = key.strip() | ||
| if key == "generation_parameters": | ||
| gen_params = re.sub(r"(\w+):", r'"\1":', value) | ||
| generation_parameters_dict = json.loads(gen_params) | ||
| if key == "chat_template_parameters": | ||
| # Chat template parameters have strings as values that also need to be quoted |
There was a problem hiding this comment.
would be relevant to have tests for parsing edge cases
LysandreJik
force-pushed
the
chat_template_parameters
branch
from
ad43991 to
20461a6
Compare
|
helpful for #855 |
lewtun
reviewed
Aug 29, 2025
| @@ -87,6 +87,7 @@ class GeneralConfigLogger: | |||
| model_size: str = None | |||
|
|
|||
| generation_parameters: dict | None = None | |||
| chat_template_parameters: dict | None = None | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables passing chat template parameters as follows:
lighteval accelerate \ model_name=Qwen/Qwen2.5-0.5B-Instruct,generation_parameters={temperature:1,top_p:1},chat_template_parameters={reasoning_effort:low} \ leaderboard|truthfulqa:mc|0|0It can probably be simplified and needs tests.